Bug Fix and Refactoring: "is-visible" was not toggled properly in Fade mode.

dist/js/splide.js

@@ -1968,6 +1968,12 @@ var STYLE_RESTORE_EVENTS = 'update.slide';
      * @return {boolean} - True if the slide is visible or false if not.
      */
     isVisible: function isVisible() {
+      var active = this.isActive();
+
+      if (Splide.is(FADE) || active) {
+        return active;
+      }
+
       var floor = Math.floor;
       var Components = Splide.Components;
       var Track = Components.Track;
@@ -1975,7 +1981,7 @@ var STYLE_RESTORE_EVENTS = 'update.slide';
       var position = floor((Track.toPosition(index) + Track.offset(index) - Track.position) * Track.sign);
       var edge = floor(position + slide[prop]);
       var size = Components.Elements.track[prop];
-      return 0 <= position && position <= size && 0 <= edge && edge <= size || this.isActive();
+      return 0 <= position && position <= size && 0 <= edge && edge <= size;
     },
 
     /**
@@ -4832,7 +4838,7 @@ var SRC_DATA_NAME = 'data-splide-lazy';
         init();
         Components.Elements.each(function (Slide) {
           each(Slide.slide.querySelectorAll("[" + SRC_DATA_NAME + "]"), function (img) {
-            if (img && !img.src) {
+            if (!img.src) {
               images.push({
                 img: img,
                 Slide: Slide
@@ -4873,7 +4879,7 @@ var SRC_DATA_NAME = 'data-splide-lazy';
 
 
   function check(index) {
-    index = index === undefined ? Splide.index : index;
+    index = isNaN(index) ? Splide.index : index;
     images = images.filter(function (image) {
       if (image.Slide.isWithin(index, options.perPage * (options.preloadPages + 1))) {
         load(image.img, image.Slide);
@@ -4883,7 +4889,7 @@ var SRC_DATA_NAME = 'data-splide-lazy';
       return true;
     }); // Unbind if all images are loaded.
 
-    if (!images.length) {
+    if (!images[0]) {
       Splide.off(NEARBY_CHECK_EVENTS);
     }
   }

src/js/components/elements/slide.js

@@ -6,7 +6,7 @@
  */
 
 import { find, addClass, removeClass, hasClass, getAttribute, setAttribute } from '../../utils/dom';
-import { SLIDE } from '../../constants/types';
+import { FADE, SLIDE } from '../../constants/types';
 import { STATUS_CLASSES } from '../../constants/classes';
 import { values } from "../../utils/object";
 import { pad } from "../../utils/utils";
@@ -133,6 +133,12 @@ export default ( Splide, index, realIndex, slide ) => {
 		 * @return {boolean} - True if the slide is visible or false if not.
 		 */
 		isVisible() {
+			const active = this.isActive();
+
+			if ( Splide.is( FADE ) || active ) {
+				return active;
+			}
+
 			const { floor }  = Math;
 			const Components = Splide.Components;
 			const Track      = Components.Track;
@@ -141,7 +147,7 @@ export default ( Splide, index, realIndex, slide ) => {
 			const edge       = floor( position + slide[ prop ] );
 			const size       = Components.Elements.track[ prop ];
 
-			return ( 0 <= position && position <= size && 0 <= edge && edge <= size ) || this.isActive();
+			return ( 0 <= position && position <= size && 0 <= edge && edge <= size );
 		},
 
 		/**

src/js/components/lazyload/index.js

@@ -93,7 +93,7 @@ export default ( Splide, Components, name ) => {
 
 				Components.Elements.each( Slide => {
 					each( Slide.slide.querySelectorAll( `[${ SRC_DATA_NAME }]` ), img => {
-						if ( img && ! img.src ) {
+						if ( ! img.src ) {
 							images.push( { img, Slide } );
 						}
 					} );
@@ -130,7 +130,7 @@ export default ( Splide, Components, name ) => {
 	 * @param {number} index - Current index.
 	 */
 	function check( index ) {
-		index = index === undefined ? Splide.index : index;
+		index = isNaN( index ) ? Splide.index : index;
 
 		images = images.filter( image => {
 			if ( image.Slide.isWithin( index, options.perPage * ( options.preloadPages + 1 ) ) ) {
@@ -141,7 +141,7 @@ export default ( Splide, Components, name ) => {
 		} );
 
 		// Unbind if all images are loaded.
-		if ( ! images.length ) {
+		if ( ! images[0] ) {
 			Splide.off( NEARBY_CHECK_EVENTS );
 		}
 	}