Sfoglia il codice sorgente

Bug Fix: Interval duration must be defined in defaults. Update test files for previous change.

Naotoshi Fujita 2 anni fa
parent
commit
bbab204c37

+ 2 - 2
src/js/components/Autoplay/Autoplay.ts

@@ -38,8 +38,8 @@ export interface AutoplayComponent extends BaseComponent {
  */
 export const Autoplay: ComponentConstructor<AutoplayComponent> = ( Splide, Components, options, event ) => {
   const { on, bind, emit } = event;
-  const { interval: duration = 5000, pauseOnHover = true, pauseOnFocus = true, resetProgress = true } = options;
-  const interval = RequestInterval( duration, Splide.go.bind( Splide, '>' ), onAnimationFrame );
+  const { interval: duration, pauseOnHover = true, pauseOnFocus = true, resetProgress = true } = options;
+  const interval = RequestInterval( duration, () => Splide.go( '>' ), onAnimationFrame );
   const { isPaused } = interval;
   const { Elements, Elements: { root, toggle } } = Components;
   const { autoplay } = options;

+ 1 - 1
src/js/components/Move/test/general.test.ts

@@ -51,7 +51,7 @@ describe( 'Move', () => {
     const { Move } = splide.Components;
     const { list } = splide.Components.Elements;
 
-    Move.move( 1, 1, -1 );
+    Move.move( 1, 1, -1, true );
 
     expect( list.style.transition ).not.toBe( '' );
 

+ 4 - 4
src/js/components/Move/test/move.test.ts

@@ -9,11 +9,11 @@ describe( 'Move#move()', () => {
     const { Move } = splide.Components;
     const { list } = splide.Components.Elements;
 
-    Move.move( 1, 1, -1 );
+    Move.move( 1, 1, -1, true );
     fire( list, 'transitionend' );
     expect( list.style.transform ).toBe( 'translateX(-200px)' );
 
-    Move.move( 2, 2, -1 );
+    Move.move( 2, 2, -1, true );
     fire( list, 'transitionend' );
     expect( list.style.transform ).toBe( 'translateX(-400px)' );
   } );
@@ -23,7 +23,7 @@ describe( 'Move#move()', () => {
     const { Move } = splide.Components;
     const { list } = splide.Components.Elements;
 
-    Move.move( 1, 1, -1 );
+    Move.move( 1, 1, -1, true );
     expect( splide.state.is( MOVING ) ).toBe( true );
 
     fire( list, 'transitionend' );
@@ -49,7 +49,7 @@ describe( 'Move#move()', () => {
       done();
     } );
 
-    Move.move( 3, 2, 1 );
+    Move.move( 3, 2, 1, true );
     fire( list, 'transitionend' );
   } );
 } );

+ 1 - 0
src/js/constants/defaults.ts

@@ -16,6 +16,7 @@ export const DEFAULTS: Options = {
   easing        : 'cubic-bezier(0.25, 1, 0.5, 1)',
   drag          : true,
   direction     : 'ltr',
+  interval      : 5000,
   trimSpace     : true,
   focusableNodes: 'a, button, textarea, input, select, iframe',
   classes       : CLASSES,