Browse Source

Bug Fix: Refresh events were removed unexpectedly.

NaotoshiFujita 5 năm trước cách đây
mục cha
commit
6c40a827b9

+ 7 - 15
dist/js/splide.js

@@ -177,15 +177,14 @@ __webpack_require__.d(states_namespaceObject, "DESTROYED", function() { return D
       }
 
       events.split(' ').forEach(function (event) {
-        for (var i in data) {
-          var item = data[i];
-
+        data = data.filter(function (item) {
           if (item && item.event === event && item.elm === elm) {
             unsubscribe(item);
-            delete data[i];
-            break;
+            return false;
           }
-        }
+
+          return true;
+        });
       });
     },
 
@@ -4785,18 +4784,11 @@ var SRC_DATA_NAME = 'data-splide-lazy';
  */
 
 /* harmony default export */ var lazyload = (function (Splide, Components, name) {
-  /**
-   * Event names for "nearby".
-   *
-   * @type {string}
-   */
-  var NEARBY_CHECK_EVENTS = "mounted refresh moved." + name;
   /**
    * Next index for sequential loading.
    *
    * @type {number}
    */
-
   var nextIndex;
   /**
    * Store objects containing an img element and a Slide object.
@@ -4856,7 +4848,7 @@ var SRC_DATA_NAME = 'data-splide-lazy';
       });
 
       if (!isSequential) {
-        Splide.on(NEARBY_CHECK_EVENTS, check);
+        Splide.on("mounted refresh moved." + name, check);
       }
     },
 
@@ -4893,7 +4885,7 @@ var SRC_DATA_NAME = 'data-splide-lazy';
     }); // Unbind if all images are loaded.
 
     if (!images[0]) {
-      Splide.off(NEARBY_CHECK_EVENTS);
+      Splide.off("moved." + name);
     }
   }
   /**

Những thai đổi đã bị hủy bỏ vì nó quá lớn
+ 0 - 0
dist/js/splide.min.js


BIN
dist/js/splide.min.js.gz


+ 2 - 9
src/js/components/lazyload/index.js

@@ -36,13 +36,6 @@ const SRC_DATA_NAME = 'data-splide-lazy';
  * @return {Object} - The component object.
  */
 export default ( Splide, Components, name ) => {
-	/**
-	 * Event names for "nearby".
-	 *
-	 * @type {string}
-	 */
-	const NEARBY_CHECK_EVENTS = `mounted refresh moved.${ name }`;
-
 	/**
 	 * Next index for sequential loading.
 	 *
@@ -105,7 +98,7 @@ export default ( Splide, Components, name ) => {
 			} );
 
 			if ( ! isSequential ) {
-				Splide.on( NEARBY_CHECK_EVENTS, check );
+				Splide.on( `mounted refresh moved.${ name }`, check );
 			}
 		},
 
@@ -142,7 +135,7 @@ export default ( Splide, Components, name ) => {
 
 		// Unbind if all images are loaded.
 		if ( ! images[0] ) {
-			Splide.off( NEARBY_CHECK_EVENTS );
+			Splide.off( `moved.${ name }` );
 		}
 	}
 

+ 5 - 6
src/js/core/event.js

@@ -45,15 +45,14 @@ export default () => {
 		 */
 		off( events, elm = null ) {
 			events.split( ' ' ).forEach( event => {
-				for ( let i in data ) {
-					const item = data[ i ];
-
+				data = data.filter( item => {
 					if ( item && item.event === event && item.elm === elm ) {
 						unsubscribe( item );
-						delete data[ i ];
-						break;
+						return false;
 					}
-				}
+
+					return true;
+				} );
 			} );
 		},
 

Một số tệp đã không được hiển thị bởi vì quá nhiều tập tin thay đổi trong này khác