Pārlūkot izejas kodu

Bug Fix: Should always rotate the loading spinner.

NaotoshiFujita 3 gadi atpakaļ
vecāks
revīzija
0c69765061

Failā izmaiņas netiks attēlotas, jo tās ir par lielu
+ 0 - 0
dist/css/splide-core.min.css


Failā izmaiņas netiks attēlotas, jo tās ir par lielu
+ 0 - 0
dist/css/splide.min.css


Failā izmaiņas netiks attēlotas, jo tās ir par lielu
+ 0 - 0
dist/css/themes/splide-default.min.css


Failā izmaiņas netiks attēlotas, jo tās ir par lielu
+ 0 - 0
dist/css/themes/splide-sea-green.min.css


Failā izmaiņas netiks attēlotas, jo tās ir par lielu
+ 0 - 0
dist/css/themes/splide-skyblue.min.css


+ 1 - 1
dist/js/splide-renderer.min.js

@@ -1,6 +1,6 @@
 /*!
 /*!
  * Splide.js
  * Splide.js
- * Version  : 3.6.5
+ * Version  : 3.6.6
  * License  : MIT
  * License  : MIT
  * Copyright: 2021 Naotoshi Fujita
  * Copyright: 2021 Naotoshi Fujita
  */
  */

+ 2 - 2
dist/js/splide.cjs.js

@@ -1,6 +1,6 @@
 /*!
 /*!
  * Splide.js
  * Splide.js
- * Version  : 3.6.5
+ * Version  : 3.6.6
  * License  : MIT
  * License  : MIT
  * Copyright: 2021 Naotoshi Fujita
  * Copyright: 2021 Naotoshi Fujita
  */
  */
@@ -2047,8 +2047,8 @@ function LazyLoad(Splide2, Components2, options) {
   function onLoad(data, error) {
   function onLoad(data, error) {
     const { _Slide } = data;
     const { _Slide } = data;
     removeClass(_Slide.slide, CLASS_LOADING);
     removeClass(_Slide.slide, CLASS_LOADING);
-    remove(data._spinner);
     if (!error) {
     if (!error) {
+      remove(data._spinner);
       display(data._img, "");
       display(data._img, "");
       emit(EVENT_LAZYLOAD_LOADED, data._img, _Slide);
       emit(EVENT_LAZYLOAD_LOADED, data._img, _Slide);
       emit(EVENT_RESIZE);
       emit(EVENT_RESIZE);

+ 2 - 2
dist/js/splide.esm.js

@@ -1,6 +1,6 @@
 /*!
 /*!
  * Splide.js
  * Splide.js
- * Version  : 3.6.5
+ * Version  : 3.6.6
  * License  : MIT
  * License  : MIT
  * Copyright: 2021 Naotoshi Fujita
  * Copyright: 2021 Naotoshi Fujita
  */
  */
@@ -2043,8 +2043,8 @@ function LazyLoad(Splide2, Components2, options) {
   function onLoad(data, error) {
   function onLoad(data, error) {
     const { _Slide } = data;
     const { _Slide } = data;
     removeClass(_Slide.slide, CLASS_LOADING);
     removeClass(_Slide.slide, CLASS_LOADING);
-    remove(data._spinner);
     if (!error) {
     if (!error) {
+      remove(data._spinner);
       display(data._img, "");
       display(data._img, "");
       emit(EVENT_LAZYLOAD_LOADED, data._img, _Slide);
       emit(EVENT_LAZYLOAD_LOADED, data._img, _Slide);
       emit(EVENT_RESIZE);
       emit(EVENT_RESIZE);

+ 2 - 2
dist/js/splide.js

@@ -4,7 +4,7 @@ function _createClass(Constructor, protoProps, staticProps) { if (protoProps) _d
 
 
 /*!
 /*!
  * Splide.js
  * Splide.js
- * Version  : 3.6.5
+ * Version  : 3.6.6
  * License  : MIT
  * License  : MIT
  * Copyright: 2021 Naotoshi Fujita
  * Copyright: 2021 Naotoshi Fujita
  */
  */
@@ -2482,9 +2482,9 @@ function _createClass(Constructor, protoProps, staticProps) { if (protoProps) _d
     function onLoad(data, error) {
     function onLoad(data, error) {
       var _Slide = data._Slide;
       var _Slide = data._Slide;
       removeClass(_Slide.slide, CLASS_LOADING);
       removeClass(_Slide.slide, CLASS_LOADING);
-      remove(data._spinner);
 
 
       if (!error) {
       if (!error) {
+        remove(data._spinner);
         display(data._img, "");
         display(data._img, "");
         emit(EVENT_LAZYLOAD_LOADED, data._img, _Slide);
         emit(EVENT_LAZYLOAD_LOADED, data._img, _Slide);
         emit(EVENT_RESIZE);
         emit(EVENT_RESIZE);

Failā izmaiņas netiks attēlotas, jo tās ir par lielu
+ 0 - 0
dist/js/splide.js.map


Failā izmaiņas netiks attēlotas, jo tās ir par lielu
+ 1 - 1
dist/js/splide.min.js


BIN
dist/js/splide.min.js.gz


+ 1 - 1
package-lock.json

@@ -1,6 +1,6 @@
 {
 {
   "name": "@splidejs/splide",
   "name": "@splidejs/splide",
-  "version": "3.6.5",
+  "version": "3.6.6",
   "lockfileVersion": 1,
   "lockfileVersion": 1,
   "requires": true,
   "requires": true,
   "dependencies": {
   "dependencies": {

+ 1 - 1
package.json

@@ -1,6 +1,6 @@
 {
 {
   "name": "@splidejs/splide",
   "name": "@splidejs/splide",
-  "version": "3.6.5",
+  "version": "3.6.6",
   "description": "Splide is a lightweight, flexible and accessible slider/carousel. No dependencies, no Lighthouse errors.",
   "description": "Splide is a lightweight, flexible and accessible slider/carousel. No dependencies, no Lighthouse errors.",
   "author": "Naotoshi Fujita",
   "author": "Naotoshi Fujita",
   "license": "MIT",
   "license": "MIT",

+ 2 - 10
src/css/core/object/objects/spinner.scss

@@ -2,13 +2,13 @@ $size: 20px !default;
 $border: 2px solid #999 !default;
 $border: 2px solid #999 !default;
 
 
 .splide {
 .splide {
-  $root: &;
-
   &__spinner {
   &__spinner {
+    animation: splide-loading 1s infinite linear;
     border: $border;
     border: $border;
     border-left-color: transparent;
     border-left-color: transparent;
     border-radius: 50%;
     border-radius: 50%;
     bottom: 0;
     bottom: 0;
+    contain: strict;
     display: inline-block;
     display: inline-block;
     height: $size;
     height: $size;
     left: 0;
     left: 0;
@@ -18,12 +18,4 @@ $border: 2px solid #999 !default;
     top: 0;
     top: 0;
     width: $size;
     width: $size;
   }
   }
-
-  &__slide {
-    &.is-loading {
-      #{ $root }__spinner {
-        animation: splide-loading 1s infinite linear;
-      }
-    }
-  }
 }
 }

+ 1 - 1
src/js/components/LazyLoad/LazyLoad.ts

@@ -176,9 +176,9 @@ export function LazyLoad( Splide: Splide, Components: Components, options: Optio
     const { _Slide } = data;
     const { _Slide } = data;
 
 
     removeClass( _Slide.slide, CLASS_LOADING );
     removeClass( _Slide.slide, CLASS_LOADING );
-    remove( data._spinner );
 
 
     if ( ! error ) {
     if ( ! error ) {
+      remove( data._spinner );
       display( data._img, '' );
       display( data._img, '' );
       emit( EVENT_LAZYLOAD_LOADED, data._img, _Slide );
       emit( EVENT_LAZYLOAD_LOADED, data._img, _Slide );
       emit( EVENT_RESIZE );
       emit( EVENT_RESIZE );

+ 2 - 1
src/js/test/php/examples/lazyLoad.php

@@ -17,10 +17,11 @@ $settings = get_settings();
   <script>
   <script>
     document.addEventListener( 'DOMContentLoaded', function () {
     document.addEventListener( 'DOMContentLoaded', function () {
       var splide01 = new Splide( '#splide01', {
       var splide01 = new Splide( '#splide01', {
-        perPage    : 1,
+        perPage    : 2,
         // type       : 'fade',
         // type       : 'fade',
         lazyLoad   : 'nearby',
         lazyLoad   : 'nearby',
         // cover      : true,
         // cover      : true,
+        drag       : 'free',
         rewind     : true,
         rewind     : true,
         heightRatio: ( 9 / 16 ) / 2,
         heightRatio: ( 9 / 16 ) / 2,
       } );
       } );

Daži faili netika attēloti, jo izmaiņu fails ir pārāk liels