Explorar el Código

Ensure libv8 is >= 3.17.11 (fixes issue #12).

C. Scott Ananian hace 11 años
padre
commit
e508410a79
Se han modificado 3 ficheros con 6 adiciones y 2 borrados
  1. 1 1
      README
  2. 1 1
      README.md
  3. 4 0
      config.m4

+ 1 - 1
README

@@ -7,7 +7,7 @@ V8js is a PHP extension for Google's V8 Javascript engine
 Minimum requirements
 --------------------
 
-- V8 library version 2.5.8 <http://code.google.com/p/v8/> (trunk)
+- V8 library version >= 3.17.11 <http://code.google.com/p/v8/> (trunk)
 
 - PHP 5.3.3+ (non-ZTS build preferred)
   Note: V8 engine is not natively thread safe and this extension

+ 1 - 1
README.md

@@ -14,7 +14,7 @@ Minimum requirements
 	V8 is Google's open source Javascript engine.
 	V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
 	V8 implements ECMAScript as specified in ECMA-262, 5th edition.
-    This extension makes use of V8 isolates to ensure separation between multiple V8Js instances, hence the need for 3.2.4 or above.
+    This extension makes use of V8 isolates to ensure separation between multiple V8Js instances, hence the need for 3.17.11 or above. (See <https://github.com/preillyme/v8js/issues/12>.)
 
 - PHP 5.3.3+
 

+ 4 - 0
config.m4

@@ -63,6 +63,10 @@ LDFLAGS=$old_LDFLAGS
     set $ac_cv_v8_version
     IFS=$ac_IFS
     V8_API_VERSION=`expr [$]1 \* 1000000 + [$]2 \* 1000 + [$]3`
+    if test "$V8_API_VERSION" -lt 3017011 ; then
+       # see https://github.com/preillyme/v8js/issues/12
+       AC_MSG_ERROR([libv8 must be version 3.17.11 or greater])
+    fi
     AC_DEFINE_UNQUOTED([PHP_V8_API_VERSION], $V8_API_VERSION, [ ])
     AC_DEFINE_UNQUOTED([PHP_V8_VERSION], "$ac_cv_v8_version", [ ])
   fi