Browse Source

Make compatible with V8 3.28.23, fixes #99

Stefan Siegl 10 years ago
parent
commit
e25e5264f6
2 changed files with 2 additions and 2 deletions
  1. 1 1
      v8js.cc
  2. 1 1
      v8js_convert.cc

+ 1 - 1
v8js.cc

@@ -914,7 +914,7 @@ static PHP_METHOD(V8Js, __construct)
 
 
 	/* Add the PHP object into global object */
 	/* Add the PHP object into global object */
 	v8::Local<v8::Object> php_obj = php_obj_t->InstanceTemplate()->NewInstance();
 	v8::Local<v8::Object> php_obj = php_obj_t->InstanceTemplate()->NewInstance();
-	V8JS_GLOBAL(isolate)->Set(object_name_js, php_obj, v8::ReadOnly);
+	V8JS_GLOBAL(isolate)->ForceSet(object_name_js, php_obj, v8::ReadOnly);
 
 
 	/* Export public property values */
 	/* Export public property values */
 	HashTable *properties = zend_std_get_properties(getThis() TSRMLS_CC);
 	HashTable *properties = zend_std_get_properties(getThis() TSRMLS_CC);

+ 1 - 1
v8js_convert.cc

@@ -986,7 +986,7 @@ static v8::Handle<v8::Value> php_v8js_hash_to_jsobj(zval *value, v8::Isolate *is
 						}
 						}
 						continue;
 						continue;
 					}
 					}
-					newobj->Set(V8JS_STRL(key, key_len - 1), zval_to_v8js(*data, isolate TSRMLS_CC), v8::ReadOnly);
+					newobj->Set(V8JS_STRL(key, key_len - 1), zval_to_v8js(*data, isolate TSRMLS_CC));
 				} else {
 				} else {
 					newobj->Set(index, zval_to_v8js(*data, isolate TSRMLS_CC));
 					newobj->Set(index, zval_to_v8js(*data, isolate TSRMLS_CC));
 				}
 				}