فهرست منبع

Fix for V8 timezone notification

Mark Grainger 2 سال پیش
والد
کامیت
51d34e0acd
2فایلهای تغییر یافته به همراه5 افزوده شده و 7 حذف شده
  1. 4 6
      tests/timezones.phpt
  2. 1 1
      v8js_v8.cc

+ 4 - 6
tests/timezones.phpt

@@ -1,8 +1,6 @@
 --TEST--
 Test V8::executeString() : Check timezone handling
 --SKIPIF--
-SKIP test currently broken, see #378
-
 <?php
 if(strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
 	die('SKIP TZ not handled by v8 on Windows');
@@ -39,7 +37,7 @@ try {
 ?>
 ===EOF===
 --EXPECT--
-Thu Mar 20 2014 11:03:24 GMT+0200 (EET)
-Thu Mar 20 2014 05:03:24 GMT-0400 (EDT)
-Thu Mar 20 2014 11:03:24 GMT+0200 (EET)
-===EOF===
+Thu Mar 20 2014 11:03:24 GMT+0200 (Eastern European Standard Time)
+Thu Mar 20 2014 05:03:24 GMT-0400 (Eastern Daylight Time)
+Thu Mar 20 2014 11:03:24 GMT+0200 (Eastern European Standard Time)
+===EOF===

+ 1 - 1
v8js_v8.cc

@@ -148,7 +148,7 @@ void v8js_v8_call(v8js_ctx *c, zval **return_value,
 				c->tz = strdup(tz);
 			}
 			else if (strcmp(c->tz, tz) != 0) {
-				c->isolate->DateTimeConfigurationChangeNotification();
+				c->isolate->DateTimeConfigurationChangeNotification(v8::Isolate::TimeZoneDetection::kRedetect);
 
 				free(c->tz);
 				c->tz = strdup(tz);