Prechádzať zdrojové kódy

Don't force garbage collection on shutdown.

Doing so causes crashes on Windows and isn't needed anymore
anyways, since we have started tracking weak references
meanwhile.
Stefan Siegl 10 rokov pred
rodič
commit
449d66ca01
1 zmenil súbory, kde vykonal 0 pridanie a 14 odobranie
  1. 0 14
      v8js.cc

+ 0 - 14
v8js.cc

@@ -677,20 +677,6 @@ static void php_v8js_free_storage(void *object TSRMLS_DC) /* {{{ */
 	}
 	c->context.~Persistent();
 
-	/* Force garbage collection on our isolate, this is needed that V8 triggers
-	 * our MakeWeak callbacks.  Without these we won't remove our references
-	 * on the PHP objects leading to memory leaks in PHP context.
-	 */
-	{
-		v8::Locker locker(c->isolate);
-		v8::Isolate::Scope isolate_scope(c->isolate);
-#if PHP_V8_API_VERSION < 3028036
-		while(!v8::V8::IdleNotification()) {};
-#else
-		while(!c->isolate->IdleNotification(500)) {};
-#endif
-	}
-
 	/* Dispose yet undisposed weak refs */
 	for (std::map<zval *, v8js_persistent_obj_t>::iterator it = c->weak_objects.begin();
 		 it != c->weak_objects.end(); ++it) {