Merge pull request #1080 from richardshiue/fix-include-time

fix: some improvements for when including time in a date cell

frontend/app_flowy/assets/translations/en.json

@@ -222,8 +222,8 @@
   "document": {
     "menuName": "Doc",
     "date": {
-      "timeHintTextInTwelveHour": "12:00 AM",
-      "timeHintTextInTwentyFourHour": "12:00"
+      "timeHintTextInTwelveHour": "01:00 PM",
+      "timeHintTextInTwentyFourHour": "13:00"
     }
   },
   "board": {

frontend/app_flowy/assets/translations/es-VE.json

@@ -210,8 +210,8 @@
   "document": {
     "menuName": "Doc",
     "date": {
-      "timeHintTextInTwelveHour": "12:00 AM",
-      "timeHintTextInTwentyFourHour": "12:00"
+      "timeHintTextInTwelveHour": "01:00 PM",
+      "timeHintTextInTwentyFourHour": "13:00"
     }
   },
   "sideBar": {

frontend/app_flowy/assets/translations/fr-FR.json

@@ -208,8 +208,8 @@
   "document": {
     "menuName": "Doc",
     "date": {
-      "timeHintTextInTwelveHour": "12:00 AM",
-      "timeHintTextInTwentyFourHour": "12:00"
+      "timeHintTextInTwelveHour": "01:00 PM",
+      "timeHintTextInTwentyFourHour": "13:00"
     }
   }
 }

frontend/app_flowy/assets/translations/id-ID.json

@@ -211,8 +211,8 @@
   "document": {
     "menuName": "Doc",
     "date": {
-      "timeHintTextInTwelveHour": "12:00 AM",
-      "timeHintTextInTwentyFourHour": "12:00"
+      "timeHintTextInTwelveHour": "01:00 PM",
+      "timeHintTextInTwentyFourHour": "13:00"
     }
   },
   "sideBar": {

frontend/app_flowy/assets/translations/ru-RU.json

@@ -221,8 +221,8 @@
   "document": {
     "menuName": "Документ",
     "date": {
-      "timeHintTextInTwelveHour": "12:00 AM",
-      "timeHintTextInTwentyFourHour": "12:00"
+      "timeHintTextInTwelveHour": "01:00 PM",
+      "timeHintTextInTwentyFourHour": "13:00"
     }
   },
   "board": {

frontend/app_flowy/assets/translations/zh-CN.json

@@ -215,8 +215,8 @@
   "document": {
     "menuName": "文档",
     "date": {
-      "timeHintTextInTwelveHour": "12:00 AM",
-      "timeHintTextInTwentyFourHour": "12:00"
+      "timeHintTextInTwelveHour": "01:00 PM",
+      "timeHintTextInTwentyFourHour": "13:00"
     }
   }
 }

frontend/app_flowy/assets/translations/zh-TW.json

@@ -211,8 +211,8 @@
   "document": {
     "menuName": "檔案",
     "date": {
-      "timeHintTextInTwelveHour": "12:00 AM",
-      "timeHintTextInTwentyFourHour": "12:00"
+      "timeHintTextInTwelveHour": "01:00 PM",
+      "timeHintTextInTwentyFourHour": "13:00"
     }
   },
   "sideBar": {

frontend/app_flowy/lib/plugins/grid/application/cell/date_cal_bloc.dart

@@ -108,7 +108,7 @@ class DateCalBloc extends Bloc<DateCalEvent, DateCalState> {
         (err) {
           switch (ErrorCode.valueOf(err.code)!) {
             case ErrorCode.InvalidDateTimeFormat:
-              updateCalData(none(), Some(timeFormatPrompt(err)));
+              updateCalData(state.calData, Some(timeFormatPrompt(err)));
               break;
             default:
               Log.error(err);
@@ -119,13 +119,13 @@ class DateCalBloc extends Bloc<DateCalEvent, DateCalState> {
   }
 
   String timeFormatPrompt(FlowyError error) {
-    String msg = "${LocaleKeys.grid_field_invalidTimeFormat.tr()}. ";
+    String msg = "${LocaleKeys.grid_field_invalidTimeFormat.tr()}.";
     switch (state.dateTypeOptionPB.timeFormat) {
       case TimeFormat.TwelveHour:
-        msg = "${msg}e.g. 01: 00 AM";
+        msg = "$msg e.g. 01:00 PM";
         break;
       case TimeFormat.TwentyFourHour:
-        msg = "${msg}e.g. 13: 00";
+        msg = "$msg e.g. 13:00";
         break;
       default:
         break;

frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_editor.dart

@@ -261,6 +261,7 @@ class _TimeTextFieldState extends State<_TimeTextField> {
             child: RoundedInputField(
               height: 40,
               focusNode: _focusNode,
+              autoFocus: true,
               hintText: state.timeHintText,
               controller: _controller,
               style: const TextStyle(fontSize: 14, fontWeight: FontWeight.w500),

frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option/date_tests.rs

@@ -141,7 +141,9 @@ mod tests {
             .unwrap();
 
         if type_option.include_time {
-            format!("{}{}", decoded_data.date, decoded_data.time)
+            format!("{} {}", decoded_data.date, decoded_data.time)
+                .trim_end()
+                .to_owned()
         } else {
             decoded_data.date
         }

frontend/rust-lib/flowy-grid/src/services/field/type_options/date_type_option/date_type_option.rs

@@ -51,8 +51,8 @@ impl DateTypeOptionPB {
         let date = format!("{}", utc.format_with_items(StrftimeItems::new(fmt)));
 
         let mut time = "".to_string();
-        if has_time {
-            let fmt = format!("{} {}", self.date_format.format_str(), self.time_format.format_str());
+        if has_time && self.include_time {
+            let fmt = format!("{}{}", self.date_format.format_str(), self.time_format.format_str());
             time = format!("{}", utc.format_with_items(StrftimeItems::new(&fmt))).replace(&date, "");
         }