Browse Source

fix: hide field & add field tests (#1340)

Co-authored-by: nathan <[email protected]>
Nathan.fooo 2 years ago
parent
commit
87247ccd9d

+ 2 - 1
frontend/app_flowy/lib/plugins/grid/application/field/field_controller.dart

@@ -16,7 +16,8 @@ class _GridFieldNotifier extends ChangeNotifier {
   List<GridFieldContext> _fieldContexts = [];
 
   set fieldContexts(List<GridFieldContext> fieldContexts) {
-    _fieldContexts = fieldContexts;
+    _fieldContexts =
+        fieldContexts.where((element) => element.visibility).toList();
     notifyListeners();
   }
 

+ 0 - 2
frontend/rust-lib/flowy-document/src/editor/document_serde.rs

@@ -1,12 +1,10 @@
 use crate::editor::document::Document;
-
 use bytes::Bytes;
 use flowy_error::FlowyResult;
 use lib_ot::core::{
     AttributeHashMap, Body, Changeset, Extension, NodeData, NodeId, NodeOperation, NodeTree, NodeTreeContext, Path,
     Selection, Transaction,
 };
-
 use lib_ot::text_delta::DeltaTextOperations;
 use serde::de::{self, MapAccess, Unexpected, Visitor};
 use serde::ser::{SerializeMap, SerializeSeq};

+ 1 - 0
frontend/rust-lib/flowy-grid/src/entities/field_entities.rs

@@ -474,6 +474,7 @@ impl FieldChangesetParams {
             || self.frozen.is_some()
             || self.type_option_data.is_some()
             || self.frozen.is_some()
+            || self.visibility.is_some()
             || self.width.is_some()
     }
 }