浏览代码

chore: fix tests

appflowy 2 年之前
父节点
当前提交
6fd36980c8
共有 1 个文件被更改,包括 4 次插入2 次删除
  1. 4 2
      frontend/rust-lib/flowy-grid/src/entities/filter_entities/select_option_filter.rs

+ 4 - 2
frontend/rust-lib/flowy-grid/src/entities/filter_entities/select_option_filter.rs

@@ -19,13 +19,15 @@ impl GridSelectOptionFilter {
         let selected_option_ids: Vec<&String> = selected_options.options.iter().map(|option| &option.id).collect();
         match self.condition {
             SelectOptionCondition::OptionIs => {
+                // if selected options equal to filter's options, then the required_options will be empty.
                 let required_options = self
                     .option_ids
                     .iter()
-                    .filter(|id| selected_option_ids.contains(id))
+                    .filter(|id| !selected_option_ids.contains(id))
                     .collect::<Vec<_>>();
+
                 // https://stackoverflow.com/questions/69413164/how-to-fix-this-clippy-warning-needless-collect
-                required_options.is_empty()
+                !required_options.is_empty()
             }
             SelectOptionCondition::OptionIsNot => {
                 for option_id in selected_option_ids {