Merge pull request #288 from NewShi/feat/once_cell_perf

feat: use once_cell for perf.

frontend/rust-lib/dart-ffi/Cargo.toml

@@ -16,13 +16,12 @@ allo-isolate = {version = "^0.1", features = ["catch-unwind",]}
 byteorder = {version = "1.3.4"}
 ffi-support = {version = "0.4.2"}
 protobuf = {version = "2.20.0"}
-lazy_static = {version = "1.4.0"}
 tokio = { version = "1", features = ["rt", "rt-multi-thread"] }
 log = "0.4.14"
 serde = { version = "1.0", features = ["derive"] }
 serde_json = {version = "1.0"}
 bytes = { version = "1.0" }
-parking_lot = "0.11"
+once_cell = "1"
 
 lib-dispatch = {path = "../lib-dispatch" }
 flowy-sdk = {path = "../flowy-sdk"}

frontend/rust-lib/dart-ffi/src/lib.rs

@@ -9,18 +9,11 @@ use crate::{
     model::{FFIRequest, FFIResponse},
 };
 use flowy_sdk::*;
-use lazy_static::lazy_static;
 use lib_dispatch::prelude::*;
-use parking_lot::RwLock;
-use std::{ffi::CStr, os::raw::c_char, sync::Arc};
+use once_cell::sync::OnceCell;
+use std::{ffi::CStr, os::raw::c_char};
 
-lazy_static! {
-    static ref FLOWY_SDK: RwLock<Option<Arc<FlowySDK>>> = RwLock::new(None);
-}
-
-fn get_dispatcher() -> Arc<EventDispatcher> {
-    FLOWY_SDK.read().as_ref().unwrap().dispatcher()
-}
+static FLOWY_SDK: OnceCell<FlowySDK> = OnceCell::new();
 
 #[no_mangle]
 pub extern "C" fn init_sdk(path: *mut c_char) -> i64 {
@@ -29,7 +22,7 @@ pub extern "C" fn init_sdk(path: *mut c_char) -> i64 {
 
     let server_config = get_client_server_configuration().unwrap();
     let config = FlowySDKConfig::new(path, server_config, "appflowy").log_filter("debug");
-    *FLOWY_SDK.write() = Some(Arc::new(FlowySDK::new(config)));
+    FLOWY_SDK.get_or_init(|| FlowySDK::new(config));
 
     0
 }
@@ -44,7 +37,15 @@ pub extern "C" fn async_event(port: i64, input: *const u8, len: usize) {
         port
     );
 
-    let _ = EventDispatcher::async_send_with_callback(get_dispatcher(), request, move |resp: EventResponse| {
+    let dispatcher = match FLOWY_SDK.get() {
+        None => {
+            log::error!("sdk not init yet.");
+
+            return;
+        }
+        Some(e) => e.dispatcher.clone(),
+    };
+    let _ = EventDispatcher::async_send_with_callback(dispatcher, request, move |resp: EventResponse| {
         log::trace!("[FFI]: Post data to dart through {} port", port);
         Box::pin(post_to_flutter(resp, port))
     });
@@ -54,7 +55,16 @@ pub extern "C" fn async_event(port: i64, input: *const u8, len: usize) {
 pub extern "C" fn sync_event(input: *const u8, len: usize) -> *const u8 {
     let request: ModuleRequest = FFIRequest::from_u8_pointer(input, len).into();
     log::trace!("[FFI]: {} Sync Event: {:?}", &request.id, &request.event,);
-    let _response = EventDispatcher::sync_send(get_dispatcher(), request);
+
+    let dispatcher = match FLOWY_SDK.get() {
+        None => {
+            log::error!("sdk not init yet.");
+
+            return forget_rust(Vec::default());
+        }
+        Some(e) => e.dispatcher.clone(),
+    };
+    let _response = EventDispatcher::sync_send(dispatcher, request);
 
     // FFIResponse {  }
     let response_bytes = vec![];