|
@@ -14,7 +14,7 @@ use flowy_collaboration::{
|
|
|
use flowy_error::FlowyResult;
|
|
|
use futures_util::{future, stream, stream::StreamExt};
|
|
|
use lib_infra::future::FutureResult;
|
|
|
-use lib_ot::{core::Operation, errors::OTError, rich_text::RichTextDelta};
|
|
|
+use lib_ot::{core::Operation, rich_text::RichTextDelta};
|
|
|
use std::{collections::VecDeque, sync::Arc};
|
|
|
use tokio::sync::RwLock;
|
|
|
|
|
@@ -26,20 +26,20 @@ pub struct DocumentRevisionManager {
|
|
|
pub(crate) doc_id: String,
|
|
|
user_id: String,
|
|
|
rev_id_counter: RevIdCounter,
|
|
|
- cache: Arc<DocumentRevisionCache>,
|
|
|
- sync_seq: Arc<RevisionSyncSequence>,
|
|
|
+ revision_cache: Arc<DocumentRevisionCache>,
|
|
|
+ revision_sync_seq: Arc<RevisionSyncSequence>,
|
|
|
}
|
|
|
|
|
|
impl DocumentRevisionManager {
|
|
|
- pub fn new(user_id: &str, doc_id: &str, cache: Arc<DocumentRevisionCache>) -> Self {
|
|
|
+ pub fn new(user_id: &str, doc_id: &str, revision_cache: Arc<DocumentRevisionCache>) -> Self {
|
|
|
let rev_id_counter = RevIdCounter::new(0);
|
|
|
- let sync_seq = Arc::new(RevisionSyncSequence::new());
|
|
|
+ let revision_sync_seq = Arc::new(RevisionSyncSequence::new());
|
|
|
Self {
|
|
|
doc_id: doc_id.to_string(),
|
|
|
user_id: user_id.to_owned(),
|
|
|
rev_id_counter,
|
|
|
- cache,
|
|
|
- sync_seq,
|
|
|
+ revision_cache,
|
|
|
+ revision_sync_seq,
|
|
|
}
|
|
|
}
|
|
|
|
|
@@ -48,7 +48,8 @@ impl DocumentRevisionManager {
|
|
|
doc_id: self.doc_id.clone(),
|
|
|
user_id: self.user_id.clone(),
|
|
|
server,
|
|
|
- cache: self.cache.clone(),
|
|
|
+ revision_cache: self.revision_cache.clone(),
|
|
|
+ revision_sync_seq: self.revision_sync_seq.clone(),
|
|
|
}
|
|
|
.load()
|
|
|
.await?;
|
|
@@ -61,7 +62,7 @@ impl DocumentRevisionManager {
|
|
|
pub async fn reset_document(&self, revisions: RepeatedRevision) -> FlowyResult<()> {
|
|
|
let rev_id = pair_rev_id_from_revisions(&revisions).1;
|
|
|
let _ = self
|
|
|
- .cache
|
|
|
+ .revision_cache
|
|
|
.reset_with_revisions(&self.doc_id, revisions.into_inner())
|
|
|
.await?;
|
|
|
self.rev_id_counter.set(rev_id);
|
|
@@ -73,7 +74,10 @@ impl DocumentRevisionManager {
|
|
|
if revision.delta_data.is_empty() {
|
|
|
return Err(FlowyError::internal().context("Delta data should be empty"));
|
|
|
}
|
|
|
- let _ = self.cache.add(revision.clone(), RevisionState::Ack, true).await?;
|
|
|
+ let _ = self
|
|
|
+ .revision_cache
|
|
|
+ .add(revision.clone(), RevisionState::Ack, true)
|
|
|
+ .await?;
|
|
|
self.rev_id_counter.set(revision.rev_id);
|
|
|
Ok(())
|
|
|
}
|
|
@@ -84,15 +88,18 @@ impl DocumentRevisionManager {
|
|
|
return Err(FlowyError::internal().context("Delta data should be empty"));
|
|
|
}
|
|
|
|
|
|
- let record = self.cache.add(revision.clone(), RevisionState::Local, true).await?;
|
|
|
- self.sync_seq.add_revision(record).await?;
|
|
|
+ let record = self
|
|
|
+ .revision_cache
|
|
|
+ .add(revision.clone(), RevisionState::Local, true)
|
|
|
+ .await?;
|
|
|
+ self.revision_sync_seq.add_revision_record(record).await?;
|
|
|
Ok(())
|
|
|
}
|
|
|
|
|
|
#[tracing::instrument(level = "debug", skip(self), err)]
|
|
|
pub async fn ack_revision(&self, rev_id: i64) -> Result<(), FlowyError> {
|
|
|
- if self.sync_seq.ack(&rev_id).await.is_ok() {
|
|
|
- self.cache.ack(rev_id).await;
|
|
|
+ if self.revision_sync_seq.ack(&rev_id).await.is_ok() {
|
|
|
+ self.revision_cache.ack(rev_id).await;
|
|
|
}
|
|
|
Ok(())
|
|
|
}
|
|
@@ -109,28 +116,28 @@ impl DocumentRevisionManager {
|
|
|
|
|
|
pub async fn get_revisions_in_range(&self, range: RevisionRange) -> Result<Vec<Revision>, FlowyError> {
|
|
|
debug_assert!(range.doc_id == self.doc_id);
|
|
|
- let revisions = self.cache.revisions_in_range(range.clone()).await?;
|
|
|
+ let revisions = self.revision_cache.revisions_in_range(range.clone()).await?;
|
|
|
Ok(revisions)
|
|
|
}
|
|
|
|
|
|
pub fn next_sync_revision(&self) -> FutureResult<Option<Revision>, FlowyError> {
|
|
|
- let sync_seq = self.sync_seq.clone();
|
|
|
- let cache = self.cache.clone();
|
|
|
+ let revision_sync_seq = self.revision_sync_seq.clone();
|
|
|
+ let revision_cache = self.revision_cache.clone();
|
|
|
FutureResult::new(async move {
|
|
|
- match sync_seq.next_sync_revision().await {
|
|
|
- None => match sync_seq.next_sync_rev_id().await {
|
|
|
+ match revision_sync_seq.next_sync_revision_record().await {
|
|
|
+ None => match revision_sync_seq.next_sync_rev_id().await {
|
|
|
None => Ok(None),
|
|
|
- Some(rev_id) => Ok(cache.get(rev_id).await.map(|record| record.revision)),
|
|
|
+ Some(rev_id) => Ok(revision_cache.get(rev_id).await.map(|record| record.revision)),
|
|
|
},
|
|
|
Some((_, record)) => Ok(Some(record.revision)),
|
|
|
}
|
|
|
})
|
|
|
}
|
|
|
|
|
|
- pub async fn latest_revision(&self) -> Revision { self.cache.latest_revision().await }
|
|
|
+ pub async fn latest_revision(&self) -> Revision { self.revision_cache.latest_revision().await }
|
|
|
|
|
|
pub async fn get_revision(&self, rev_id: i64) -> Option<Revision> {
|
|
|
- self.cache.get(rev_id).await.map(|record| record.revision)
|
|
|
+ self.revision_cache.get(rev_id).await.map(|record| record.revision)
|
|
|
}
|
|
|
}
|
|
|
|
|
@@ -152,12 +159,17 @@ impl std::default::Default for RevisionSyncSequence {
|
|
|
impl RevisionSyncSequence {
|
|
|
fn new() -> Self { RevisionSyncSequence::default() }
|
|
|
|
|
|
- async fn add_revision(&self, record: RevisionRecord) -> Result<(), OTError> {
|
|
|
+ async fn add_revision_record(&self, record: RevisionRecord) -> FlowyResult<()> {
|
|
|
+ if !record.state.is_local() {
|
|
|
+ return Ok(());
|
|
|
+ }
|
|
|
+
|
|
|
// The last revision's rev_id must be greater than the new one.
|
|
|
if let Some(rev_id) = self.local_revs.read().await.back() {
|
|
|
if *rev_id >= record.revision.rev_id {
|
|
|
- return Err(OTError::revision_id_conflict()
|
|
|
- .context(format!("The new revision's id must be greater than {}", rev_id)));
|
|
|
+ return Err(
|
|
|
+ FlowyError::internal().context(format!("The new revision's id must be greater than {}", rev_id))
|
|
|
+ );
|
|
|
}
|
|
|
}
|
|
|
self.local_revs.write().await.push_back(record.revision.rev_id);
|
|
@@ -181,7 +193,7 @@ impl RevisionSyncSequence {
|
|
|
Ok(())
|
|
|
}
|
|
|
|
|
|
- async fn next_sync_revision(&self) -> Option<(i64, RevisionRecord)> {
|
|
|
+ async fn next_sync_revision_record(&self) -> Option<(i64, RevisionRecord)> {
|
|
|
match self.local_revs.read().await.front() {
|
|
|
None => None,
|
|
|
Some(rev_id) => self.revs_map.get(rev_id).map(|r| (*r.key(), r.value().clone())),
|
|
@@ -195,12 +207,13 @@ struct RevisionLoader {
|
|
|
doc_id: String,
|
|
|
user_id: String,
|
|
|
server: Arc<dyn RevisionServer>,
|
|
|
- cache: Arc<DocumentRevisionCache>,
|
|
|
+ revision_cache: Arc<DocumentRevisionCache>,
|
|
|
+ revision_sync_seq: Arc<RevisionSyncSequence>,
|
|
|
}
|
|
|
|
|
|
impl RevisionLoader {
|
|
|
async fn load(&self) -> Result<Vec<Revision>, FlowyError> {
|
|
|
- let records = self.cache.batch_get(&self.doc_id)?;
|
|
|
+ let records = self.revision_cache.batch_get(&self.doc_id)?;
|
|
|
let revisions: Vec<Revision>;
|
|
|
if records.is_empty() {
|
|
|
let doc = self.server.fetch_document(&self.doc_id).await?;
|
|
@@ -214,16 +227,24 @@ impl RevisionLoader {
|
|
|
&self.user_id,
|
|
|
doc_md5,
|
|
|
);
|
|
|
- let _ = self.cache.add(revision.clone(), RevisionState::Ack, true).await?;
|
|
|
+ let _ = self
|
|
|
+ .revision_cache
|
|
|
+ .add(revision.clone(), RevisionState::Ack, true)
|
|
|
+ .await?;
|
|
|
revisions = vec![revision];
|
|
|
} else {
|
|
|
- // Sync the records if their state is RevisionState::Local.
|
|
|
stream::iter(records.clone())
|
|
|
.filter(|record| future::ready(record.state == RevisionState::Local))
|
|
|
.for_each(|record| async move {
|
|
|
- match self.cache.add(record.revision, record.state, false).await {
|
|
|
+ let f = || async {
|
|
|
+ // Sync the records if their state is RevisionState::Local.
|
|
|
+ let _ = self.revision_sync_seq.add_revision_record(record.clone()).await?;
|
|
|
+ let _ = self.revision_cache.add(record.revision, record.state, false).await?;
|
|
|
+ Ok::<(), FlowyError>(())
|
|
|
+ };
|
|
|
+ match f().await {
|
|
|
Ok(_) => {},
|
|
|
- Err(e) => tracing::error!("{}", e),
|
|
|
+ Err(e) => tracing::error!("[RevisionLoader]: {}", e),
|
|
|
}
|
|
|
})
|
|
|
.await;
|
|
@@ -274,5 +295,5 @@ impl RevisionSyncSequence {
|
|
|
|
|
|
#[cfg(feature = "flowy_unit_test")]
|
|
|
impl DocumentRevisionManager {
|
|
|
- pub fn revision_cache(&self) -> Arc<DocumentRevisionCache> { self.cache.clone() }
|
|
|
+ pub fn revision_cache(&self) -> Arc<DocumentRevisionCache> { self.revision_cache.clone() }
|
|
|
}
|